Fangjun Kuang
Committed by GitHub

Fix uploading win32 libs to huggingface (#2537)

This PR fixes the uploading process for win32 libraries to Hugging Face by updating Windows OS detection and correcting the file copy destination path.

- Replaces deprecated wmic command with PowerShell-based OS detection for better reliability
- Adds fallback mechanism using cmd /c ver when PowerShell is unavailable
- Corrects the destination path for win32 library archives to include version subdirectory
... ... @@ -130,7 +130,7 @@ jobs:
dst=win32/$SHERPA_ONNX_VERSION
mkdir -p $dst
cp -v ../sherpa-onnx-*.tar.bz2 ./win32
cp -v ../sherpa-onnx-*.tar.bz2 $dst
git status
git lfs track "*.bz2"
... ...
... ... @@ -55,16 +55,30 @@ elseif(APPLE)
)
set(SHERPA_ONNX_OS "${_product_name} ${_product_version} ${_build_version}")
elseif(WIN32)
execute_process(COMMAND
wmic os get caption,version
OUTPUT_VARIABLE SHERPA_ONNX_OS_TWO_LINES
# Try PowerShell first to get OS name + version
execute_process(
COMMAND powershell -NoProfile -Command "(Get-CimInstance Win32_OperatingSystem).Caption + ' ' + (Get-CimInstance Win32_OperatingSystem).Version"
OUTPUT_VARIABLE SHERPA_ONNX_OS
OUTPUT_STRIP_TRAILING_WHITESPACE
ERROR_QUIET
)
# Now SHERPA_ONNX_OS_TWO_LINES contains something like
# Caption Version
# Microsoft Windows 10 Pro 10.0.18362
string(REPLACE "\n" ";" SHERPA_ONNX_OS_LIST ${SHERPA_ONNX_OS_TWO_LINES})
list(GET SHERPA_ONNX_OS_LIST 1 SHERPA_ONNX_OS)
if(NOT SHERPA_ONNX_OS)
message(WARNING "PowerShell not available, falling back to cmd /c ver")
# Fallback: cmd.exe /c ver (only version info, less detailed)
execute_process(
COMMAND cmd /c ver
OUTPUT_VARIABLE _cmd_out
OUTPUT_STRIP_TRAILING_WHITESPACE
ERROR_QUIET
)
string(REPLACE "\r" "" _cmd_out "${_cmd_out}")
if(_cmd_out)
set(SHERPA_ONNX_OS "Windows ${_cmd_out}")
else()
set(SHERPA_ONNX_OS "Windows (version unknown)")
endif()
endif()
else()
set(SHERPA_ONNX_OS "Unknown")
endif()
... ...