winlin

fix the bug by refine code, rename the get_perfer_cid to get_prefer_cid.

@@ -1879,7 +1879,7 @@ int SrsConnectAppPacket::decode(SrsStream* stream) @@ -1879,7 +1879,7 @@ int SrsConnectAppPacket::decode(SrsStream* stream)
1879 return ret; 1879 return ret;
1880 } 1880 }
1881 1881
1882 -int SrsConnectAppPacket::get_perfer_cid() 1882 +int SrsConnectAppPacket::get_prefer_cid()
1883 { 1883 {
1884 return RTMP_CID_OverConnection; 1884 return RTMP_CID_OverConnection;
1885 } 1885 }
@@ -1993,7 +1993,7 @@ int SrsConnectAppResPacket::decode(SrsStream* stream) @@ -1993,7 +1993,7 @@ int SrsConnectAppResPacket::decode(SrsStream* stream)
1993 return ret; 1993 return ret;
1994 } 1994 }
1995 1995
1996 -int SrsConnectAppResPacket::get_perfer_cid() 1996 +int SrsConnectAppResPacket::get_prefer_cid()
1997 { 1997 {
1998 return RTMP_CID_OverConnection; 1998 return RTMP_CID_OverConnection;
1999 } 1999 }
@@ -2105,7 +2105,7 @@ int SrsCallPacket::decode(SrsStream* stream) @@ -2105,7 +2105,7 @@ int SrsCallPacket::decode(SrsStream* stream)
2105 return ret; 2105 return ret;
2106 } 2106 }
2107 2107
2108 -int SrsCallPacket::get_perfer_cid() 2108 +int SrsCallPacket::get_prefer_cid()
2109 { 2109 {
2110 return RTMP_CID_OverConnection; 2110 return RTMP_CID_OverConnection;
2111 } 2111 }
@@ -2179,7 +2179,7 @@ SrsCallResPacket::~SrsCallResPacket() @@ -2179,7 +2179,7 @@ SrsCallResPacket::~SrsCallResPacket()
2179 srs_freep(response); 2179 srs_freep(response);
2180 } 2180 }
2181 2181
2182 -int SrsCallResPacket::get_perfer_cid() 2182 +int SrsCallResPacket::get_prefer_cid()
2183 { 2183 {
2184 return RTMP_CID_OverConnection; 2184 return RTMP_CID_OverConnection;
2185 } 2185 }
@@ -2282,7 +2282,7 @@ int SrsCreateStreamPacket::decode(SrsStream* stream) @@ -2282,7 +2282,7 @@ int SrsCreateStreamPacket::decode(SrsStream* stream)
2282 return ret; 2282 return ret;
2283 } 2283 }
2284 2284
2285 -int SrsCreateStreamPacket::get_perfer_cid() 2285 +int SrsCreateStreamPacket::get_prefer_cid()
2286 { 2286 {
2287 return RTMP_CID_OverConnection; 2287 return RTMP_CID_OverConnection;
2288 } 2288 }
@@ -2373,7 +2373,7 @@ int SrsCreateStreamResPacket::decode(SrsStream* stream) @@ -2373,7 +2373,7 @@ int SrsCreateStreamResPacket::decode(SrsStream* stream)
2373 return ret; 2373 return ret;
2374 } 2374 }
2375 2375
2376 -int SrsCreateStreamResPacket::get_perfer_cid() 2376 +int SrsCreateStreamResPacket::get_prefer_cid()
2377 { 2377 {
2378 return RTMP_CID_OverConnection; 2378 return RTMP_CID_OverConnection;
2379 } 2379 }
@@ -2509,7 +2509,7 @@ int SrsFMLEStartPacket::decode(SrsStream* stream) @@ -2509,7 +2509,7 @@ int SrsFMLEStartPacket::decode(SrsStream* stream)
2509 return ret; 2509 return ret;
2510 } 2510 }
2511 2511
2512 -int SrsFMLEStartPacket::get_perfer_cid() 2512 +int SrsFMLEStartPacket::get_prefer_cid()
2513 { 2513 {
2514 return RTMP_CID_OverConnection; 2514 return RTMP_CID_OverConnection;
2515 } 2515 }
@@ -2630,7 +2630,7 @@ int SrsFMLEStartResPacket::decode(SrsStream* stream) @@ -2630,7 +2630,7 @@ int SrsFMLEStartResPacket::decode(SrsStream* stream)
2630 return ret; 2630 return ret;
2631 } 2631 }
2632 2632
2633 -int SrsFMLEStartResPacket::get_perfer_cid() 2633 +int SrsFMLEStartResPacket::get_prefer_cid()
2634 { 2634 {
2635 return RTMP_CID_OverConnection; 2635 return RTMP_CID_OverConnection;
2636 } 2636 }
@@ -2733,7 +2733,7 @@ int SrsPublishPacket::decode(SrsStream* stream) @@ -2733,7 +2733,7 @@ int SrsPublishPacket::decode(SrsStream* stream)
2733 return ret; 2733 return ret;
2734 } 2734 }
2735 2735
2736 -int SrsPublishPacket::get_perfer_cid() 2736 +int SrsPublishPacket::get_prefer_cid()
2737 { 2737 {
2738 return RTMP_CID_OverStream; 2738 return RTMP_CID_OverStream;
2739 } 2739 }
@@ -2931,7 +2931,7 @@ int SrsPlayPacket::decode(SrsStream* stream) @@ -2931,7 +2931,7 @@ int SrsPlayPacket::decode(SrsStream* stream)
2931 return ret; 2931 return ret;
2932 } 2932 }
2933 2933
2934 -int SrsPlayPacket::get_perfer_cid() 2934 +int SrsPlayPacket::get_prefer_cid()
2935 { 2935 {
2936 return RTMP_CID_OverStream; 2936 return RTMP_CID_OverStream;
2937 } 2937 }
@@ -3014,7 +3014,7 @@ SrsPlayResPacket::~SrsPlayResPacket() @@ -3014,7 +3014,7 @@ SrsPlayResPacket::~SrsPlayResPacket()
3014 srs_freep(desc); 3014 srs_freep(desc);
3015 } 3015 }
3016 3016
3017 -int SrsPlayResPacket::get_perfer_cid() 3017 +int SrsPlayResPacket::get_prefer_cid()
3018 { 3018 {
3019 return RTMP_CID_OverStream; 3019 return RTMP_CID_OverStream;
3020 } 3020 }
@@ -3076,7 +3076,7 @@ SrsOnBWDonePacket::~SrsOnBWDonePacket() @@ -3076,7 +3076,7 @@ SrsOnBWDonePacket::~SrsOnBWDonePacket()
3076 srs_freep(args); 3076 srs_freep(args);
3077 } 3077 }
3078 3078
3079 -int SrsOnBWDonePacket::get_perfer_cid() 3079 +int SrsOnBWDonePacket::get_prefer_cid()
3080 { 3080 {
3081 return RTMP_CID_OverConnection; 3081 return RTMP_CID_OverConnection;
3082 } 3082 }
@@ -3133,7 +3133,7 @@ SrsOnStatusCallPacket::~SrsOnStatusCallPacket() @@ -3133,7 +3133,7 @@ SrsOnStatusCallPacket::~SrsOnStatusCallPacket()
3133 srs_freep(data); 3133 srs_freep(data);
3134 } 3134 }
3135 3135
3136 -int SrsOnStatusCallPacket::get_perfer_cid() 3136 +int SrsOnStatusCallPacket::get_prefer_cid()
3137 { 3137 {
3138 return RTMP_CID_OverStream; 3138 return RTMP_CID_OverStream;
3139 } 3139 }
@@ -3229,7 +3229,7 @@ int SrsBandwidthPacket::decode(SrsStream *stream) @@ -3229,7 +3229,7 @@ int SrsBandwidthPacket::decode(SrsStream *stream)
3229 return ret; 3229 return ret;
3230 } 3230 }
3231 3231
3232 -int SrsBandwidthPacket::get_perfer_cid() 3232 +int SrsBandwidthPacket::get_prefer_cid()
3233 { 3233 {
3234 return RTMP_CID_OverStream; 3234 return RTMP_CID_OverStream;
3235 } 3235 }
@@ -3418,7 +3418,7 @@ SrsOnStatusDataPacket::~SrsOnStatusDataPacket() @@ -3418,7 +3418,7 @@ SrsOnStatusDataPacket::~SrsOnStatusDataPacket()
3418 srs_freep(data); 3418 srs_freep(data);
3419 } 3419 }
3420 3420
3421 -int SrsOnStatusDataPacket::get_perfer_cid() 3421 +int SrsOnStatusDataPacket::get_prefer_cid()
3422 { 3422 {
3423 return RTMP_CID_OverStream; 3423 return RTMP_CID_OverStream;
3424 } 3424 }
@@ -3465,7 +3465,7 @@ SrsSampleAccessPacket::~SrsSampleAccessPacket() @@ -3465,7 +3465,7 @@ SrsSampleAccessPacket::~SrsSampleAccessPacket()
3465 { 3465 {
3466 } 3466 }
3467 3467
3468 -int SrsSampleAccessPacket::get_perfer_cid() 3468 +int SrsSampleAccessPacket::get_prefer_cid()
3469 { 3469 {
3470 return RTMP_CID_OverStream; 3470 return RTMP_CID_OverStream;
3471 } 3471 }
@@ -586,7 +586,7 @@ public: @@ -586,7 +586,7 @@ public:
586 virtual int decode(SrsStream* stream); 586 virtual int decode(SrsStream* stream);
587 // encode functions for concrete packet to override. 587 // encode functions for concrete packet to override.
588 public: 588 public:
589 - virtual int get_perfer_cid(); 589 + virtual int get_prefer_cid();
590 virtual int get_message_type(); 590 virtual int get_message_type();
591 protected: 591 protected:
592 virtual int get_size(); 592 virtual int get_size();
@@ -623,7 +623,7 @@ public: @@ -623,7 +623,7 @@ public:
623 virtual int decode(SrsStream* stream); 623 virtual int decode(SrsStream* stream);
624 // encode functions for concrete packet to override. 624 // encode functions for concrete packet to override.
625 public: 625 public:
626 - virtual int get_perfer_cid(); 626 + virtual int get_prefer_cid();
627 virtual int get_message_type(); 627 virtual int get_message_type();
628 protected: 628 protected:
629 virtual int get_size(); 629 virtual int get_size();
@@ -664,7 +664,7 @@ public: @@ -664,7 +664,7 @@ public:
664 virtual int decode(SrsStream* stream); 664 virtual int decode(SrsStream* stream);
665 // encode functions for concrete packet to override. 665 // encode functions for concrete packet to override.
666 public: 666 public:
667 - virtual int get_perfer_cid(); 667 + virtual int get_prefer_cid();
668 virtual int get_message_type(); 668 virtual int get_message_type();
669 protected: 669 protected:
670 virtual int get_size(); 670 virtual int get_size();
@@ -697,7 +697,7 @@ public: @@ -697,7 +697,7 @@ public:
697 virtual ~SrsCallResPacket(); 697 virtual ~SrsCallResPacket();
698 // encode functions for concrete packet to override. 698 // encode functions for concrete packet to override.
699 public: 699 public:
700 - virtual int get_perfer_cid(); 700 + virtual int get_prefer_cid();
701 virtual int get_message_type(); 701 virtual int get_message_type();
702 protected: 702 protected:
703 virtual int get_size(); 703 virtual int get_size();
@@ -734,7 +734,7 @@ public: @@ -734,7 +734,7 @@ public:
734 virtual int decode(SrsStream* stream); 734 virtual int decode(SrsStream* stream);
735 // encode functions for concrete packet to override. 735 // encode functions for concrete packet to override.
736 public: 736 public:
737 - virtual int get_perfer_cid(); 737 + virtual int get_prefer_cid();
738 virtual int get_message_type(); 738 virtual int get_message_type();
739 protected: 739 protected:
740 virtual int get_size(); 740 virtual int get_size();
@@ -770,7 +770,7 @@ public: @@ -770,7 +770,7 @@ public:
770 virtual int decode(SrsStream* stream); 770 virtual int decode(SrsStream* stream);
771 // encode functions for concrete packet to override. 771 // encode functions for concrete packet to override.
772 public: 772 public:
773 - virtual int get_perfer_cid(); 773 + virtual int get_prefer_cid();
774 virtual int get_message_type(); 774 virtual int get_message_type();
775 protected: 775 protected:
776 virtual int get_size(); 776 virtual int get_size();
@@ -833,7 +833,7 @@ public: @@ -833,7 +833,7 @@ public:
833 virtual int decode(SrsStream* stream); 833 virtual int decode(SrsStream* stream);
834 // encode functions for concrete packet to override. 834 // encode functions for concrete packet to override.
835 public: 835 public:
836 - virtual int get_perfer_cid(); 836 + virtual int get_prefer_cid();
837 virtual int get_message_type(); 837 virtual int get_message_type();
838 protected: 838 protected:
839 virtual int get_size(); 839 virtual int get_size();
@@ -873,7 +873,7 @@ public: @@ -873,7 +873,7 @@ public:
873 virtual int decode(SrsStream* stream); 873 virtual int decode(SrsStream* stream);
874 // encode functions for concrete packet to override. 874 // encode functions for concrete packet to override.
875 public: 875 public:
876 - virtual int get_perfer_cid(); 876 + virtual int get_prefer_cid();
877 virtual int get_message_type(); 877 virtual int get_message_type();
878 protected: 878 protected:
879 virtual int get_size(); 879 virtual int get_size();
@@ -927,7 +927,7 @@ public: @@ -927,7 +927,7 @@ public:
927 virtual int decode(SrsStream* stream); 927 virtual int decode(SrsStream* stream);
928 // encode functions for concrete packet to override. 928 // encode functions for concrete packet to override.
929 public: 929 public:
930 - virtual int get_perfer_cid(); 930 + virtual int get_prefer_cid();
931 virtual int get_message_type(); 931 virtual int get_message_type();
932 protected: 932 protected:
933 virtual int get_size(); 933 virtual int get_size();
@@ -1044,7 +1044,7 @@ public: @@ -1044,7 +1044,7 @@ public:
1044 virtual int decode(SrsStream* stream); 1044 virtual int decode(SrsStream* stream);
1045 // encode functions for concrete packet to override. 1045 // encode functions for concrete packet to override.
1046 public: 1046 public:
1047 - virtual int get_perfer_cid(); 1047 + virtual int get_prefer_cid();
1048 virtual int get_message_type(); 1048 virtual int get_message_type();
1049 protected: 1049 protected:
1050 virtual int get_size(); 1050 virtual int get_size();
@@ -1082,7 +1082,7 @@ public: @@ -1082,7 +1082,7 @@ public:
1082 virtual ~SrsPlayResPacket(); 1082 virtual ~SrsPlayResPacket();
1083 // encode functions for concrete packet to override. 1083 // encode functions for concrete packet to override.
1084 public: 1084 public:
1085 - virtual int get_perfer_cid(); 1085 + virtual int get_prefer_cid();
1086 virtual int get_message_type(); 1086 virtual int get_message_type();
1087 protected: 1087 protected:
1088 virtual int get_size(); 1088 virtual int get_size();
@@ -1112,7 +1112,7 @@ public: @@ -1112,7 +1112,7 @@ public:
1112 virtual ~SrsOnBWDonePacket(); 1112 virtual ~SrsOnBWDonePacket();
1113 // encode functions for concrete packet to override. 1113 // encode functions for concrete packet to override.
1114 public: 1114 public:
1115 - virtual int get_perfer_cid(); 1115 + virtual int get_prefer_cid();
1116 virtual int get_message_type(); 1116 virtual int get_message_type();
1117 protected: 1117 protected:
1118 virtual int get_size(); 1118 virtual int get_size();
@@ -1148,7 +1148,7 @@ public: @@ -1148,7 +1148,7 @@ public:
1148 virtual ~SrsOnStatusCallPacket(); 1148 virtual ~SrsOnStatusCallPacket();
1149 // encode functions for concrete packet to override. 1149 // encode functions for concrete packet to override.
1150 public: 1150 public:
1151 - virtual int get_perfer_cid(); 1151 + virtual int get_prefer_cid();
1152 virtual int get_message_type(); 1152 virtual int get_message_type();
1153 protected: 1153 protected:
1154 virtual int get_size(); 1154 virtual int get_size();
@@ -1191,7 +1191,7 @@ public: @@ -1191,7 +1191,7 @@ public:
1191 virtual int decode(SrsStream* stream); 1191 virtual int decode(SrsStream* stream);
1192 // encode functions for concrete packet to override. 1192 // encode functions for concrete packet to override.
1193 public: 1193 public:
1194 - virtual int get_perfer_cid(); 1194 + virtual int get_prefer_cid();
1195 virtual int get_message_type(); 1195 virtual int get_message_type();
1196 protected: 1196 protected:
1197 virtual int get_size(); 1197 virtual int get_size();
@@ -1245,7 +1245,7 @@ public: @@ -1245,7 +1245,7 @@ public:
1245 virtual ~SrsOnStatusDataPacket(); 1245 virtual ~SrsOnStatusDataPacket();
1246 // encode functions for concrete packet to override. 1246 // encode functions for concrete packet to override.
1247 public: 1247 public:
1248 - virtual int get_perfer_cid(); 1248 + virtual int get_prefer_cid();
1249 virtual int get_message_type(); 1249 virtual int get_message_type();
1250 protected: 1250 protected:
1251 virtual int get_size(); 1251 virtual int get_size();
@@ -1280,7 +1280,7 @@ public: @@ -1280,7 +1280,7 @@ public:
1280 virtual ~SrsSampleAccessPacket(); 1280 virtual ~SrsSampleAccessPacket();
1281 // encode functions for concrete packet to override. 1281 // encode functions for concrete packet to override.
1282 public: 1282 public:
1283 - virtual int get_perfer_cid(); 1283 + virtual int get_prefer_cid();
1284 virtual int get_message_type(); 1284 virtual int get_message_type();
1285 protected: 1285 protected:
1286 virtual int get_size(); 1286 virtual int get_size();
@@ -64,8 +64,15 @@ MockSrsConfig::~MockSrsConfig() @@ -64,8 +64,15 @@ MockSrsConfig::~MockSrsConfig()
64 64
65 int MockSrsConfig::parse(string buf) 65 int MockSrsConfig::parse(string buf)
66 { 66 {
  67 + int ret = ERROR_SUCCESS;
  68 +
67 MockSrsConfigBuffer buffer(buf); 69 MockSrsConfigBuffer buffer(buf);
68 - return parse_buffer(&buffer); 70 +
  71 + if ((ret = parse_buffer(&buffer)) != ERROR_SUCCESS) {
  72 + return ret;
  73 + }
  74 +
  75 + return check_config();
69 } 76 }
70 77
71 #ifdef ENABLE_UTEST_CONFIG 78 #ifdef ENABLE_UTEST_CONFIG