正在显示
1 个修改的文件
包含
3 行增加
和
0 行删除
trunk/src/core/srs_core_encoder.cpp
100644 → 100755
| @@ -216,6 +216,7 @@ int SrsFFMPEG::start() | @@ -216,6 +216,7 @@ int SrsFFMPEG::start() | ||
| 216 | char s_achannels[10]; | 216 | char s_achannels[10]; |
| 217 | snprintf(s_achannels, sizeof(s_achannels), "%d", achannels); | 217 | snprintf(s_achannels, sizeof(s_achannels), "%d", achannels); |
| 218 | 218 | ||
| 219 | + // TODO: execl donot support the params. | ||
| 219 | // video params | 220 | // video params |
| 220 | std::string s_vpreset = vpreset; | 221 | std::string s_vpreset = vpreset; |
| 221 | if (!vparams.empty()) { | 222 | if (!vparams.empty()) { |
| @@ -229,6 +230,7 @@ int SrsFFMPEG::start() | @@ -229,6 +230,7 @@ int SrsFFMPEG::start() | ||
| 229 | s_aparams += aparams; | 230 | s_aparams += aparams; |
| 230 | } | 231 | } |
| 231 | 232 | ||
| 233 | + // TODO: fork or vfork? | ||
| 232 | if ((pid = fork()) < 0) { | 234 | if ((pid = fork()) < 0) { |
| 233 | ret = ERROR_ENCODER_FORK; | 235 | ret = ERROR_ENCODER_FORK; |
| 234 | srs_error("vfork process failed. ret=%d", ret); | 236 | srs_error("vfork process failed. ret=%d", ret); |
| @@ -237,6 +239,7 @@ int SrsFFMPEG::start() | @@ -237,6 +239,7 @@ int SrsFFMPEG::start() | ||
| 237 | 239 | ||
| 238 | // child process: ffmpeg encoder engine. | 240 | // child process: ffmpeg encoder engine. |
| 239 | if (pid == 0) { | 241 | if (pid == 0) { |
| 242 | + // TODO: execl or execlp | ||
| 240 | ret = execl(ffmpeg.c_str(), | 243 | ret = execl(ffmpeg.c_str(), |
| 241 | ffmpeg.c_str(), | 244 | ffmpeg.c_str(), |
| 242 | "-f", "flv", | 245 | "-f", "flv", |
-
请 注册 或 登录 后发表评论